-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Change admin indicator to icon-only #34586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
templates/base/head_navbar.tmpl
Outdated
@@ -130,8 +130,7 @@ | |||
<span class="only-mobile">{{.SignedUser.Name}}</span> | |||
<span class="not-mobile">{{svg "octicon-triangle-down"}}</span> | |||
</span> | |||
{{/* do not localize it, here it needs the fixed length (width) to make UI comfortable */}} | |||
{{if .IsAdmin}}<span class="navbar-profile-admin">admin</span>{{end}} | |||
{{if .IsAdmin}}<span class="navbar-profile-admin" title="{{ctx.Locale.Tr "repo.settings.collaboration.admin"}}">{{svg "octicon-server" 11}}</span>{{end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think it's right. That text is for "repo admin"
But here it is "site admin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm right, I guess we can just remove the title completely. Unfortunately, there is no suitable existing translation and I would like to backport.
Besides the "text" problem, the "icon" is more not-suitable .... why there is a "server" icon next to the user's avatar, it seems more strange. |
But it still confuses users at first glance. And the icon is also inconsistent with other navbar items like "notification", "stopwatch": they all use the blue balls. |
I read such blue dots as "activity indicator", but admin info is not such a state, it's a user attribute. |
+1 |
Could move it, yeah. It doesn't have to be same position as the other blue activity indcators. |
Any other suggestions? Things about the current icon that I don't like:
|
Change admin indicator in navbar to icon only, which looks better imho, and the icon is the same as "Site Administration" in this menu, which is exactly what the admin role gives access to. User can hover over the icon to get a native
title
tooltip which localized text.Works with any avatar and is now aligned to the notifications and stopwatch dots:
(Before there was slight misalignment):
Active state: