adding benchmark query with lots of rows #1703
Closed
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new benchmark function, Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
benchmark_test.go (1)
116-155: Good addition of the benchmark for large result sets.The new benchmark effectively tests the performance of retrieving and scanning a large number of rows, which is a valuable addition to the benchmark suite. This will help track driver performance for large result set processing.
A few suggestions for improvement:
- Add
b.ReportAllocs()beforeb.StartTimer()to report memory allocations (consistent with other benchmarks in this file).- Add a check for
rows.Err()after the scanning loop to catch any errors that occurred during iteration.- Consider adding a brief comment explaining the benchmark's purpose and the dependency on MariaDB's
seq_1_to_10000table.func BenchmarkSelect10000rows(b *testing.B) { db := initDB(b, false) defer db.Close() // Check if we're using MariaDB var version string err := db.QueryRow("SELECT @@version").Scan(&version) if err != nil { b.Fatalf("Failed to get server version: %v", err) } if !strings.Contains(strings.ToLower(version), "mariadb") { b.Skip("Skipping benchmark as it requires MariaDB sequence table") return } + b.ReportAllocs() b.StartTimer() stmt, err := db.Prepare("SELECT * FROM seq_1_to_10000") if err != nil { b.Fatalf("Failed to prepare statement: %v", err) } defer stmt.Close() for n := 0; n < b.N; n++ { rows, err := stmt.Query() if err != nil { b.Fatalf("Failed to query 10000rows: %v", err) } var id int64 for rows.Next() { err = rows.Scan(&id) if err != nil { rows.Close() b.Fatalf("Failed to scan row: %v", err) } } + if err = rows.Err(); err != nil { + rows.Close() + b.Fatalf("Error during row iteration: %v", err) + } rows.Close() } b.StopTimer() }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
benchmark_test.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
- GitHub Check: test (macos-latest, 1.24, mariadb-10.11)
- GitHub Check: test (windows-latest, 1.24, mariadb-10.6)
- GitHub Check: test (macos-latest, 1.24, mariadb-11.4)
- GitHub Check: test (macos-latest, 1.24, mariadb-11.2)
- GitHub Check: test (ubuntu-latest, 1.22, 9.0)
- GitHub Check: test (windows-latest, 1.24, mariadb-10.11)
- GitHub Check: test (macos-latest, 1.24, 8.0)
- GitHub Check: test (windows-latest, 1.24, 5.7)
- GitHub Check: test (windows-latest, 1.24, 9.0)
- GitHub Check: test (windows-latest, 1.24, mariadb-10.5)
- GitHub Check: test (windows-latest, 1.24, mariadb-11.2)
- GitHub Check: test (windows-latest, 1.24, 8.4)
- GitHub Check: test (windows-latest, 1.24, mariadb-11.4)
- GitHub Check: test (macos-latest, 1.24, mariadb-11.1)
- GitHub Check: test (ubuntu-latest, 1.24, mariadb-10.5)
- GitHub Check: test (windows-latest, 1.24, mariadb-11.1)
- GitHub Check: test (windows-latest, 1.24, 8.0)
- GitHub Check: test (ubuntu-latest, 1.24, 5.7)
methane
reviewed
Apr 22, 2025
methane
reviewed
Apr 22, 2025
methane
reviewed
Apr 22, 2025
|
Sorry. I missed there is BenchmarkReceiveMassiveRows already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
created only a benchmark addition for #1697
Checklist
Summary by CodeRabbit