Skip to content

Fix EditorInspector tooltip disappearing in special cases #105576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

GustJc
Copy link
Contributor

@GustJc GustJc commented Apr 20, 2025

Fixes #104672
Fixes #105572

EditorInspector tooltips seems to be affected by waccom drivers after #95044
This makes ProjectSettings, EditorSettings and Inspector tooltips disappear very fast even if you don't move the mouse.
Having a waccom driver installed seems to be enough for this to happen, as I have this issue without a pen tablet connected.

Disabling the internal process of the tooltip's EditorHelpBitTooltip solves this issue.
Everything is still working fine on windows. But some testing in other OS's would be appreciated.

Problem:

latest.mp4

Fixed:

fix.mp4

PS: Feel free to close this PR if someone more knowledgeable knows how to fix this issue in a better way.

@GustJc GustJc force-pushed the fix_tooltip_disappearing branch from cbf2a2e to 7e79c07 Compare April 20, 2025 16:52
@GustJc
Copy link
Contributor Author

GustJc commented Apr 20, 2025

So, I've take a better look on the problem. For some reason on windows, when using the "wintab" driver, the update mouse velocity is a bit delayed. So when the tooltip is created, it triggers,
Because the mouse speed just before you put the mouse inside the tooltip is still there.

if (!_is_mouse_inside_tooltip && OS::get_singleton()->get_ticks_msec() - _enter_tree_time > 250) {
    _start_timer();
}

Increasing this time a little bit seems to solve the issue.

My guess is that the tooltip delay to start the tooltip in inspectors is about 200~250 ms, and a few ms delay that wintab creates is just enough for it to trigger this.

Also a note: the docs and other tooltips are handled very differently, they don't have this 'fix' and work in any case no matter the delay. The tooltip delay ProjectSettings only affect them. And InspectorEditor tooltips are always about a 250ms delay to popup.

But this I feel is another issue that should be handled separately.
For now, adjusting this delay fixes the driver tooltip disappearing issue.

@GustJc GustJc requested a review from dalexeev April 20, 2025 17:03
@akien-mga akien-mga requested a review from bruvzg May 13, 2025 22:43
@akien-mga akien-mga added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label May 13, 2025
@Repiteo Repiteo merged commit bd73ab4 into godotengine:master May 15, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented May 15, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:editor
Projects
None yet
6 participants