Skip to content

Move NavigationRegion3DGizmoPlugin to navigation_3d module. #105593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Apr 20, 2025

Moves NavigationRegion3DGizmoPlugin to navigation_3d module.

Gizmo file move PR but since the editor plugin needs to register the gizmo plugin this PR is build on top of #105592 that should be merged first.

@smix8 smix8 added this to the 4.5 milestone Apr 20, 2025
@smix8 smix8 requested review from a team as code owners April 20, 2025 17:07
@smix8 smix8 force-pushed the navregion_3d_gizmo_plugin branch 2 times, most recently from 87c2c62 to 5998100 Compare May 6, 2025 16:02
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I think you would have made your life easier by keeping all changes in the same PR, they're all pretty straightforward IMO and the self-imposed conflicts could have been avoided :D

@smix8
Copy link
Contributor Author

smix8 commented May 6, 2025

Seems fine. I think you would have made your life easier by keeping all changes in the same PR, they're all pretty straightforward IMO and the self-imposed conflicts could have been avoided :D

Let me revel in my rebase misery, I did not plan them at first which is why they ended up being multiple PRs (minutes!) apart.

Moves NavigationRegion3DGizmoPlugin to navigation_3d module.
@smix8 smix8 force-pushed the navregion_3d_gizmo_plugin branch from 5998100 to 63bd35e Compare May 6, 2025 18:49
@Repiteo Repiteo merged commit e9ddf57 into godotengine:master May 7, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented May 7, 2025

Thanks!

@smix8 smix8 deleted the navregion_3d_gizmo_plugin branch May 8, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants