-
Notifications
You must be signed in to change notification settings - Fork 352
_content: add styles for mod table #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 8844d82) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/592955. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Gihwan Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
@0x1306e6d I wasn't able to add this comment on Gerrit for some reason: While I opened the bug for the environment variables table in particular, every table in the same page is affected (there are quite a few if you search for I'm not sure if other pages in the Go docs are similarly affected. I sampled a few other prominent doc pages, but based on those, it doesn't seem like tables are used often in general. |
Hi @jjlin I've updated all tables in the mod page. PTAL. |
This PR (HEAD: 7646862) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/592955. Important tips:
|
Message from Sean Liao: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-12T12:12:48Z","revision":"f96b119089f5324a7d3aa8bb5890a99f4dcd7f1b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Sean Liao: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/x_website-gotip-linux-amd64-boringcrypto has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Sean Liao: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-12T12:27:33Z","revision":"cac1ad0ab12366c2f35714a72e552a166108f696"} Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Sean Liao: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Michael Pratt: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Sean Liao: Patch Set 4: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Message from Michael Pratt: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. |
Make Environment variables table readable: align table cell to top and add
border between rows.
Fixes golang/go#67368