Skip to content

Treat any yapf exit code as an error case, not just exit code 1 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

Treat any yapf exit code as an error case, not just exit code 1 #165

merged 1 commit into from
Nov 12, 2020

Conversation

dbarnett
Copy link
Contributor

Fixes #61.

@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@malcolmr malcolmr self-requested a review November 10, 2020 08:01
malcolmr
malcolmr approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@malcolmr malcolmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbarnett dbarnett merged commit d418de0 into master Nov 12, 2020
@dbarnett dbarnett deleted the yapf_error branch March 27, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmr malcolmr malcolmr approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yapf code formatting deletes file if it does not parse
2 participants
@dbarnett @malcolmr