feat(spanner): support for type UUID #2235
Conversation
product-auto-label
bot
added
size: m
alkatrivedi
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
size: l
alkatrivedi
force-pushed
the
uuid-support
branch
11 times, most recently
from
b31705d to
69cf752
Compare
alkatrivedi
force-pushed
the
uuid-support
branch
from
69cf752 to
5738698
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
sakthivelmanii
added
the
do not merge
| @@ -814,6 +817,10 @@ function getType(value: Value): Type { | |||
| return {type: 'bool'}; | |||
| } | |||
|
|
|||
| if (uuid.validate(value)) { | |||
| return {type: 'unspecified'}; | |||
There was a problem hiding this comment.
why unspecified here?
There was a problem hiding this comment.
cause we are not sure if the customer has inserted the UUID value in the column of type UUID/String. Hence, we are returning type as unspecified implicitly, but while making gRPC call we are making sure that if the type is unspecified we don't pass param type with the gaxOptions, this way are letting backend to figure out the type
There was a problem hiding this comment.
@sakthivelmanii uuid value can be send for String column as well. So we want to make use of "unspecified" type and let backend decide it.
Ideally we should not have removed the type mapping when backend started suplorting untyped params, but we did not remove this because of breaking changes.
There was a problem hiding this comment.
But will this work for parameterized queries. I think parameterized queries does not support UNSPECIFIED type.
@alkatrivedi can you check if parameterized query is working when passing a UUID value?
There was a problem hiding this comment.
The case that we are talking about here is when customer triggers a following parameterized query without an explicit param type
const query = {
sql: 'SELECT @v',
params: {
v: values,
},
};
I think this fails if value is of UUID type and param type is not mentioned because client now sends a UNSPECIFIED type to backend
There was a problem hiding this comment.
My suggestion here is
Ideally, if param type is not mentioned then treat the value as string.
If customer wants to treat that value as UUID then they can explicitly specify the param type.
There was a problem hiding this comment.
based on the discussion with @harshachinta and @surbhigarg92
we will return the type as unspecified, allowing the backend to determine the type of the value provided
regarding the query - 'SELECT @v'
failure in this case, where the parameter type is not inferred, is expected behavior. since the query does not target a specific table, deriving type dynamically is not a valid scenario
| @@ -814,6 +817,10 @@ function getType(value: Value): Type { | |||
| return {type: 'bool'}; | |||
| } | |||
|
|
|||
| if (uuid.validate(value)) { | |||
| return {type: 'unspecified'}; | |||
There was a problem hiding this comment.
@sakthivelmanii uuid value can be send for String column as well. So we want to make use of "unspecified" type and let backend decide it.
Ideally we should not have removed the type mapping when backend started suplorting untyped params, but we did not remove this because of breaking changes.
surbhigarg92
added
do not merge
This PR contains support for UUID type on Cloud Spanner.