Fix fill method in injection script

[ankur22]

What?

Preventing an early exit in the fill method in the injection script to actually allow the keyboard to enter the value into the input element.

Why?

This fill function was failing to fill the input text field. It would seem that it was returning to early, when it should have continued onto the end of the function and returned "needsinput".

Test script

Without the fix this script was unable to enter the username in the input element. After the fix it does:

import { browser } from 'k6/browser';

export const options = {
  scenarios: {
    ui: {
      executor: 'shared-iterations',
      options: {
        browser: {
          type: "chromium",
        },
      },
    },
  }
}

export default async function() {
  const context = await browser.newContext();
  const page = await context.newPage();

  await page.goto('https://grafana.com/auth/sign-in');
  
  await page.locator('input[name="login"]').fill('my-username');

  await page.waitForTimeout(5000);
}

Checklist

• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added tests for my changes.
• I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

• I have added the correct milestone and labels to the PR.
• I have updated the release notes: link
• I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
• I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

[joanlopez]

Is this something that can be tested? Like, with a unit test, I mean 🤔

[ankur22]

Is this something that can be tested? Like, with a unit test, I mean 🤔

I did try, and i wasn't able to get it to not work before the fix! Very strange. I'll give it another go though 👍

[ankur22]

@joanlopez I've added an integration test in 9a35675. It fails without the fix and passes with the fix. Turned out to be an issue due how react works.

[mstoykov]

In general it is not great when our test depends on other services being up and running and we have tried to remove those.

#464 #2302

[joanlopez]

I guess a "quick-win" could be copy-pasting these files locally, right? 🤔 So, this way we don't rely on an external server, to be available. Reproducing the issue (if React-specific) with a subset of the library might more challenging, tho.

[mstoykov]

LGTM, but it will be nice if we do not have to import 2 react dependancies from a third party to test this.