-
Notifications
You must be signed in to change notification settings - Fork 157
Dev container fixes and updates #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RembrandtK
wants to merge
11
commits into
main
Choose a base branch
from
dev-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More robust handling of unusual filenames. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dev container configuration and supporting scripts, removing unused dependencies and enhancing documentation. Key changes include:
- A new script (scripts/count-changes) to count Solidity code changes using cloc.
- Removal of the shared network dependency and duplicate Git SSH signing message in the dev container settings.
- Updates to the Dockerfile to remove global Hardhat installation and install only the necessary packages.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
scripts/count-changes | Adds a script for counting Solidity code changes using cloc. |
packages/issuance/lib/forge-std | Adds a submodule commit reference for the forge-std library. |
.devcontainer/project-setup.sh | Removes a duplicate Git SSH signing message to avoid redundancy. |
.devcontainer/docker-compose.yml | Removes the unneeded shared network configuration. |
.devcontainer/README.md | Updates documentation for clarity regarding container usage. |
.devcontainer/Dockerfile | Eliminates global Hardhat installation; now installs ethers and cloc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and updates:
scripts/count-changes not about dev container but useful script.
Everything else relates just to dev container configuration.