Create GCI120 angular rule #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hindsellouk , could you :
|
|
@hindsellouk I think this rule is to generic, Angular doc said that "It could be usefull" and "It may be effective on performance". So this rule is situational and it's difficult to determine if it should be used (with static analysis) |
utarwyn
reviewed
May 31, 2025
There was a problem hiding this comment.
Hello! Thank you for the first Angular rule proposal 🥳
I also think we lack precise measurements of the effectiveness and relevance of using OnPush rather than the default detection system. Can you provide us with precise documentation and why not run some benchmarks ourselves?
It will also be very useful to reference them in the rule documentation. In the meantime, I propose not to merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.