Skip to content

r/aws_eks_cluster: Supports null compute_config.node_role_arn when disabling auto mode or built-in node pools #42483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lorengordon
Copy link
Contributor

Description

Supports setting compute_config.node_role_arn to null when disabling auto mode or built-in node pools

Relations

Relates #40582 (Actually closes the issue, in my opinion.)

@lorengordon lorengordon requested a review from a team as a code owner May 5, 2025 16:48
Copy link

github-actions bot commented May 5, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 5, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. labels May 5, 2025
@lorengordon lorengordon force-pushed the fix/eks-auto-mode-node-role-arn branch from e7bfad8 to c13dcd6 Compare May 5, 2025 16:50
@lorengordon
Copy link
Contributor Author

I based the work on #41925. I'm not too sure how to write golang tests to account for the scenarios this is fixing. But I did manage to build the binary and test using a dev override, and can confirm it is working as intended. It does allow removing the built-in node pools and setting the node role arn to null, without replacing the cluster. And can also disable auto mode and null the node role arn without replacing the cluster.

@lorengordon lorengordon force-pushed the fix/eks-auto-mode-node-role-arn branch from c13dcd6 to 432ba88 Compare May 6, 2025 13:02
@lorengordon lorengordon force-pushed the fix/eks-auto-mode-node-role-arn branch 2 times, most recently from 1f746a7 to 9b1ae19 Compare May 7, 2025 17:49
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2025
@lorengordon lorengordon force-pushed the fix/eks-auto-mode-node-role-arn branch 6 times, most recently from 3f42b92 to 324c98c Compare May 14, 2025 15:10
…disabling auto mode or built-in node pools
@lorengordon lorengordon force-pushed the fix/eks-auto-mode-node-role-arn branch from 324c98c to d610014 Compare May 15, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants