-
Notifications
You must be signed in to change notification settings - Fork 9.5k
r/aws_eks_cluster: Supports null compute_config.node_role_arn
when disabling auto mode or built-in node pools
#42483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
e7bfad8
to
c13dcd6
Compare
I based the work on #41925. I'm not too sure how to write golang tests to account for the scenarios this is fixing. But I did manage to build the binary and test using a dev override, and can confirm it is working as intended. It does allow removing the built-in node pools and setting the node role arn to |
c13dcd6
to
432ba88
Compare
1f746a7
to
9b1ae19
Compare
3f42b92
to
324c98c
Compare
…disabling auto mode or built-in node pools
324c98c
to
d610014
Compare
Description
Supports setting
compute_config.node_role_arn
tonull
when disabling auto mode or built-in node poolsRelations
Relates #40582 (Actually closes the issue, in my opinion.)