Skip to content

[New Data Source] aws_wafv2_web_acls: retrieve a list of Web ACL names #42500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented May 6, 2025

Description

  • Add a new data source, aws_wafv2_web_acls, which retrieves a list of Web ACL names for the specified scope.

Relations

Closes #42004

Issue #42004 requested filter functionality by name, but it is not implemented because the corresponding AWS API, ListWebACLs, does not support filtering by name.
This functionality can instead be achieved by filtering the output of this data source using a for expression, as demonstrated in the example provided in the documentation.

References

https://docs.aws.amazon.com/ja_jp/waf/latest/APIReference/API_ListWebACLs.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccWAFV2WebACLsDataSource_ PKG=wafv2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/wafv2/... -v -count 1 -parallel 10 -run='TestAccWAFV2WebACLsDataSource_'  -timeout 360m -vet=off
2025/05/07 00:54:20 Initializing Terraform AWS Provider...
=== RUN   TestAccWAFV2WebACLsDataSource_basic
=== PAUSE TestAccWAFV2WebACLsDataSource_basic
=== CONT  TestAccWAFV2WebACLsDataSource_basic
--- PASS: TestAccWAFV2WebACLsDataSource_basic (38.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      42.378s

Copy link

github-actions bot commented May 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 6, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wafv2 Issues and PRs that pertain to the wafv2 service. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. labels May 6, 2025
@tabito-hara tabito-hara force-pushed the f-aws_wafv2_web_acls-add_data_source branch from 6591cda to 4a7882b Compare May 6, 2025 16:09
@tabito-hara tabito-hara marked this pull request as ready for review May 6, 2025 17:14
@tabito-hara tabito-hara requested a review from a team as a code owner May 6, 2025 17:14
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Data resource aws_wafv2_web_acls
2 participants