-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[Enhancement] aws_codepipeline: support for Compute
action
#42507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tabito-hara
wants to merge
6
commits into
hashicorp:main
Choose a base branch
from
tabito-hara:f-aws_codepipeline-add_commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Enhancement] aws_codepipeline: support for Compute
action
#42507
tabito-hara
wants to merge
6
commits into
hashicorp:main
from
tabito-hara:f-aws_codepipeline-add_commands
+325
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
enhancement
Requests to existing resources that expand the functionality or scope.
service/codepipeline
Issues and PRs that pertain to the codepipeline service.
size/XL
Managed by automation to categorize the size of a PR.
sweeper
Pertains to changes to or issues with the sweeper.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add several arguments to the
action
block to support theCompute
action:commands
output_variables
output_artifacts_for_compute_action
output_artifacts
is implemented as a list of artifact names.Compute
action uses thefiles
attribute inOutputArtifacts
, which cannot be represented using the currentoutput_artifacts
.output_artifacts_for_compute_action
, has been introduced. Its schema matches that of theOutputArtifacts
object in the AWS API.Compute
,output_artifacts_for_compute_action
is used andoutput_artifacts
is ignored.This PR is based on f/aws_codepipeline add 'commands' attribute to support 'Compute' action category #41034, rebased onto the latest
main
branch, and adds theoutput_variables
andoutput_artifacts_for_compute_action
arguments.Relations
Closes #39743
Relates #41034
References
https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_ActionDeclaration.html#CodePipeline-Type-ActionDeclaration-commands
https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-Commands.html
Output from Acceptance Testing