-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[New Resource] - AWS WAF APIKey #42525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccWAFV2APIKey_' PKG=wafv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run=TestAccWAFV2APIKey_ -timeout 360m -vet=off
2025/05/12 09:01:56 Initializing Terraform AWS Provider...
=== RUN TestAccWAFV2APIKey_basic
=== PAUSE TestAccWAFV2APIKey_basic
=== RUN TestAccWAFV2APIKey_multipleTokenDomains
=== PAUSE TestAccWAFV2APIKey_multipleTokenDomains
=== RUN TestAccWAFV2APIKey_changeTokenDomainsForceNew
=== PAUSE TestAccWAFV2APIKey_changeTokenDomainsForceNew
=== RUN TestAccWAFV2APIKey_disappears
=== PAUSE TestAccWAFV2APIKey_disappears
=== CONT TestAccWAFV2APIKey_basic
=== CONT TestAccWAFV2APIKey_changeTokenDomainsForceNew
=== CONT TestAccWAFV2APIKey_disappears
=== CONT TestAccWAFV2APIKey_multipleTokenDomains
--- PASS: TestAccWAFV2APIKey_multipleTokenDomains (14.93s)
--- PASS: TestAccWAFV2APIKey_basic (21.54s)
--- PASS: TestAccWAFV2APIKey_changeTokenDomainsForceNew (24.62s)
--- PASS: TestAccWAFV2APIKey_disappears (28.67s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/wafv2 33.477s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@pavloos Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR adds new resource for WAF APIKey
Relations
Closes #39286
Output from Acceptance Testing