[Enhancement] aws_iot_domain_configuration: support for application protocol and authentication type

[badmintoncryer]

Description

Add support for application_protocol and authentication_type for AWS IoT Domain Configuration.

In order to create an update test to modify the authentication_type, it is necessary to set the appropriate application_protocol.

link: https://docs.aws.amazon.com/iot/latest/developerguide/protocols.html

 make testacc TESTS=TestAccIoTDomainConfiguration_update PKG=iot
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTDomainConfiguration_update'  -timeout 360m -vet=off
2025/05/08 22:44:35 Initializing Terraform AWS Provider...
=== RUN   TestAccIoTDomainConfiguration_update
=== PAUSE TestAccIoTDomainConfiguration_update
=== CONT  TestAccIoTDomainConfiguration_update
    domain_configuration_test.go:144: Step 1/3 error: Error running apply: exit status 1
        
        Error: creating IoT Domain Configuration (tf-acc-test-4977357272255903369): operation error IoT: CreateDomainConfiguration, https response error StatusCode: 400, RequestID: 2c6e97fb-8cdd-4cb4-8b8b-c39bada93664, InvalidRequestException: The domain must configure a supported ApplicationProtocol when configuring an AuthenticationType. Please refer to <https://docs.aws.amazon.com/iot/latest/developerguide/protocols.html> for supported combinations and try again.
        
          with aws_iot_domain_configuration.test,
          on terraform_plugin_test.tf line 76, in resource "aws_iot_domain_configuration" "test":
          76: resource "aws_iot_domain_configuration" "test" {
        
--- FAIL: TestAccIoTDomainConfiguration_update (87.78s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/iot        94.612s
FAIL
make: *** [testacc] Error 1

Therefore, it was difficult to create an acc test for a PR that only adds authentication_type.
As a result, I have included the addition of two arguments in the same PR.

Relations

Relates #40949

References

API Reference: https://docs.aws.amazon.com/iot/latest/apireference/API_CreateDomainConfiguration.html#iot-CreateDomainConfiguration-request-authenticationType

Output from Acceptance Testing

make testacc TESTS=TestAccIoTDomainConfiguration_update PKG=iot
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTDomainConfiguration_update'  -timeout 360m -vet=off
2025/05/08 23:14:25 Initializing Terraform AWS Provider...
=== RUN   TestAccIoTDomainConfiguration_update
=== PAUSE TestAccIoTDomainConfiguration_update
=== CONT  TestAccIoTDomainConfiguration_update
--- PASS: TestAccIoTDomainConfiguration_update (150.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        157.512s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

[ewbankkit]

LGTM 🚀.

% ACM_CERTIFICATE_ROOT_DOMAIN=...  make testacc TESTARGS='-run=TestAccIoTDomainConfiguration_' PKG=iot ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/iot/... -v -count 1 -parallel 3  -run=TestAccIoTDomainConfiguration_ -timeout 360m -vet=off
2025/05/11 17:39:33 Initializing Terraform AWS Provider...
=== RUN   TestAccIoTDomainConfiguration_basic
=== PAUSE TestAccIoTDomainConfiguration_basic
=== RUN   TestAccIoTDomainConfiguration_disappears
=== PAUSE TestAccIoTDomainConfiguration_disappears
=== RUN   TestAccIoTDomainConfiguration_tags
=== PAUSE TestAccIoTDomainConfiguration_tags
=== RUN   TestAccIoTDomainConfiguration_update
=== PAUSE TestAccIoTDomainConfiguration_update
=== RUN   TestAccIoTDomainConfiguration_awsManaged
    domain_configuration_test.go:188: Environment variable IOT_DOMAIN_CONFIGURATION_TEST_AWS_MANAGED is not set, skipping test
--- SKIP: TestAccIoTDomainConfiguration_awsManaged (0.00s)
=== CONT  TestAccIoTDomainConfiguration_basic
=== CONT  TestAccIoTDomainConfiguration_tags
=== CONT  TestAccIoTDomainConfiguration_disappears
--- PASS: TestAccIoTDomainConfiguration_disappears (84.25s)
=== CONT  TestAccIoTDomainConfiguration_update
--- PASS: TestAccIoTDomainConfiguration_basic (85.29s)
--- PASS: TestAccIoTDomainConfiguration_tags (108.23s)
--- PASS: TestAccIoTDomainConfiguration_update (97.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	186.361s

[ewbankkit]

LGTM 🚀.

[jar-b]

LGTM 🚀

[ewbankkit]

@badmintoncryer Thanks for the contribution 🎉 👏.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!