Skip to content

aws_sagemaker_image_version add support for aliases #42609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

aws_sagemaker_image_version add support for aliases #42609

wants to merge 2 commits into from

Conversation

psantus
Copy link
Contributor

@psantus psantus commented May 14, 2025

Description

Adds support for aliases in aws_sagemaker_image_versionresource.

It required to refactor resourceImageVersionRead because the AWS SDK doesn't have an Aliases field in DescribeImageVersionOutput.

Nota : this PR is on top of #42606.

Relations

Closes #35931

References

CreateImageVersion supports aliases
DescribeImageVersion doesn't return aliases
But we have a handy ListAliases API that helps

Output from Acceptance Testing

% cd ./internal/service/sagemaker && TF_ACC=1 SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=<REDACTED>.dkr.ecr.us-west-2.amazonaws.com/terraform-test:latest AWS_PROFILE=<REDACTED> go test -v -run="^TestAccSageMakerImageVersion_full$"

2025/05/14 01:54:28 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerImageVersion_full
=== PAUSE TestAccSageMakerImageVersion_full
=== CONT  TestAccSageMakerImageVersion_full
--- PASS: TestAccSageMakerImageVersion_full (110.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  114.588s


...

@github-actions GitHub Actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. labels May 14, 2025
@psantus psantus force-pushed the f/sagemaker_image_version-add-missing-metadata branch from febf463 to 91eb736 Compare May 14, 2025 00:06
@psantus psantus marked this pull request as ready for review May 14, 2025 00:06
@psantus psantus requested a review from a team as a code owner May 14, 2025 00:06
@psantus
Copy link
Contributor Author

psantus commented May 14, 2025

@jar-b shall I rebase this on #42536 / release/6.0.0-beta ?

@psantus psantus mentioned this pull request May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: add missing metadata arguments to aws_sagemaker_image_version
1 participant
@psantus