-
Notifications
You must be signed in to change notification settings - Fork 711
Adding JavaScript Preprocessor Support #10967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cabal-syntax/src/Distribution/PackageDescription/FieldGrammar.hs
Outdated
Show resolved
Hide resolved
I'm confused about the JSP naming scheme. I think the naming in GHC with optP, and optJSP is rather poor, but we have |
Ping @GulinSS re ghc naming?? |
0cacc4b
to
8703783
Compare
Hm, well, now I know why we use Let's use anything what follow existing rules without copying |
e1aa91a
to
02ebc9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few places which might need modifications. Looks like a good start, and thanks for the tests.
I think now it looks the way I like it. The tests are written and are being passed :) |
@Mikolaj @Swordlash @phadej @angerman You might also be interested in this pull request 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Wow, thanks for picking this up. |
Add JSPOptions tests Add regressions tests Co-authored-by: Mateusz Goslinowski <mateusz.goslinowski@gmail.com>
-optJSP
was added toghc
similar to-optP
for cpp.I suggest supporting this change.
Implemented as discussed in #10722
Will close issue #10721
Template Α: This PR modifies behaviour or interface
Manual QA notes have been included.