Skip to content

Findings from the essentials course #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 14, 2025

Conversation

hageboeck
Copy link
Contributor

Running list of improvements from the 12th instalment

@hageboeck hageboeck self-assigned this Mar 10, 2025
@chavid
Copy link
Contributor

chavid commented Mar 10, 2025

Side comment: the print helper is handy but may be frightening for beginners.

@chavid
Copy link
Contributor

chavid commented Mar 10, 2025

The final exercise (loospRefsAuto) was somehow redundant with the third one (functions). Not sure how to improve this.

@chavid
Copy link
Contributor

chavid commented Mar 10, 2025

It would help to have more explicit recommendations on the required minimal version of g++ and clang++... which would require an easy way to check that a given version is ok for all exercises ? Perhaps already done in the CI.

@chavid
Copy link
Contributor

chavid commented Mar 10, 2025

I see (only now) that there are many installation instructions in the exercices/README. Fine ! Is it somehow up to date ? Probably it deserves a dedicated file that we may review regularly.

@hageboeck
Copy link
Contributor Author

Side comment: the print helper is handy but may be frightening for beginners.

I added a NOTE that it's not part of the exercise.

It would help to have more explicit recommendations on the required minimal version of g++ and clang++... which would require an easy way to check that a given version is ok for all exercises ? Perhaps already done in the CI.

The CI already checks that exercises compile with the respective versions. You are right that we have to remember to update this part

### Required
- decent C++ editor
- any C++ compiler supporting C++20
- C++17 compiler will do for most of the exercises though
- git for getting/managing your code

when we move to C++23.

The check_setup.sh also checks compiler versions:

# compiler
check_tool g++ 10.0.0 false || check_tool clang++ 11.0.0 false || { echo -e "${RED}No supported compiler found${NORMAL}"; exit_status=1; } # clang does not work for header_units exercise

@hageboeck hageboeck marked this pull request as ready for review March 14, 2025 11:16
@hageboeck hageboeck requested a review from sponce March 14, 2025 11:16
@hageboeck hageboeck merged commit 8f9cbfb into hsf-training:master Mar 14, 2025
4 checks passed
@hageboeck hageboeck deleted the essentials_25 branch March 14, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants