Skip to content

Add missing secretName for Ingress #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hijbk304
Copy link

Add missing secretName on create Ingress. For #2254

Copy link

openshift-ci bot commented Apr 29, 2025

Hi @Hijbk304. Thanks for your PR.

I'm waiting for a infinispan member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Crumby
Copy link
Collaborator

Crumby commented May 14, 2025

@Hijbk304 @ryanemerson I don't think the solution here will be as simple as adding the secretName to the Ingress specs. According Ingress TLS documenationt it requires for the secret to have data in tls.crt and tls.key format. And while we support that we also support keystore.p12 format which wouldn't work.

The second and probably more important issue is that Ingress with TLS terminates the encryption and forwards plain text but the server is still configured for the encrypted communication. I suspect the PR as is doesn't work but I didn't get a chance to test it and we run the tests with NodePort configuration in the CI/CD only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants