Add phonenumber -> libphonenumber mapping

[JackKelly-Bellroy]

No description provided.

[michaelpj]

Have you got an example of a package that uses this, OOI?

[JackKelly-Bellroy]

Someone has made a library that calls into it:

https://github.com/typeable/libphonenumber/blob/5e03e45e2ef02b17a9d0ec3b1e951ef7214cba4a/libphonenumber.cabal#L77-L78

But I don't have any publicly available code that consumes the Haskell phonenumber library.

[mrBliss]

We use phonenumber too and have a similar mapping in our code, so a +1 from me. The code is private, though.

[michaelpj]

Thanks!

[JackKelly-Bellroy]

@mrBliss How did you get Haskell packages that depend upon phonenumber to compile properly? We are hitting missing symbol errors that look like they come from icu:

Error relocating /nix/store/hkarhp3g68y0912xn43xlmxpwmik1csr-phonenumber-x86_64-unknown-linux-musl-8.13.36/lib/libphonenumber.so.8: _ZN6icu_736UStackD1Ev: symbol not found

It's not clear to me whether the build is failing to find a .so at all, or successfully finding a .so which doesn't provide the necessary symbols. Did you have to make other build system tweaks?

[mrBliss]

@JackKelly-Bellroy The only things we did are:

• Add a dependency on phone-numbers in our .cabal file.
  • Because we want some of the changes that haven't made it into a release, we pin a git version in our Stack snapshot.
• We have the following overlay:

  self: super: {
    phonenumber = self.libphonenumber;
  }
  which is no longer necessary after this PR.

That's it.

I see you're using musl whereas we are using glibc. Looking at all the special casing for musl in haskell.nix, I'm guessing that might have something to do with it? Maybe this line:

  icu = (prev.icu.overrideAttrs (old: { configureFlags = old.configureFlags ++ [ "--enable-static" "--disable-shared" ]; }));