Skip to content

*stm32:usart - optimise code use inlinings #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

*stm32:usart - optimise code use inlinings #55

wants to merge 1 commit into from

Conversation

alexrayne
Copy link

moved some simple code from body to headers inlines

danielinux
danielinux reviewed May 20, 2017
View reviewed changes
Copy link
Contributor

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this kind of optimization is required for UART. Not much gain in terms of performance, and the code size would actually grow if the compiler actually decides to inline these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinux danielinux danielinux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrayne @danielinux