Skip to content

Support for packagist #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pensiero
Copy link

@pensiero pensiero commented Dec 30, 2017

Thanks to this PR, users will be able to import your library inside their project thanks to composer and packagist.

In case you approve the PR, you should also create a release (here on GitHub) and submit your repo to packagist.org. I already did this with my repo, in order to use it in my projects. In case I can remove it.

Some extra contained in this repo:

  • Added custom exceptions
  • Code cleaned and updated (thanks to PHP Inspections plugin)
  • Simplified the namespace (OpensslCryptor instead of ioncube\phpOpensslCryptor); I referred to standard conventions that are widely used around open source PHP projects on GitHub (camelcase and only one word); moreover i stripped the word php, that is not useful (we are working within a php environment); if you don't like it, and you prefer something else, don't hesitate to tell me

Fixes #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant