Skip to content

Moves curriculum manager call to after scene reset #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsmith-bdai
Copy link
Collaborator

Description

Moves the curriculum manager compute method to come after scene.reset() has been called to allow curriculum managers to set information related to external wrenches on an articulation. Previously, any attempt to set the external wrench buffers will be cleared after calling scene.reset() which calls the articulation reset.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jsmith-bdai jsmith-bdai requested a review from Mayankm96 as a code owner April 1, 2025 18:24
@jsmith-bdai jsmith-bdai requested a review from Copilot April 1, 2025 18:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug related to the curriculum manager call by moving its compute method to execute after the scene reset.

  • Removed the curriculum manager call before scene.reset().
  • Added the curriculum manager call after scene.reset() to prevent the external wrench buffer from being cleared.

@jsmith-bdai jsmith-bdai changed the title Move curriculum manager call to after scene reset Moves curriculum manager call to after scene reset Apr 2, 2025
@jsmith-bdai jsmith-bdai requested a review from kellyguo11 April 17, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant