Skip to content

add events, observations and terminations file #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calmdw
Copy link

@calmdw calmdw commented Apr 8, 2025

Description

Hello, I am using the ./isaaclab.sh --new to generate one internal manager-based project, but I notice in the mdp only has one rewards file, based on our team experience, we also customize the events, observations and terminations especially introducing the contact force, therefore I suggest to add events, observations and terminations files together when generating new project.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Before:
image

After:
image

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • [Not need] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Signed-off-by: Calm_dw <89777028+calmdw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant