Skip to content

feat: support importing R data files into JASP #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

feat: support importing R data files into JASP #5841

wants to merge 5 commits into from

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Apr 11, 2025 •
edited
Loading

Now we using librdata to import .RData/.rds files into JASP! Compiling librdata on Windows is still not silky🤔 because librdata is not on conan but I had opened a PR for conan repo, but it cannot build with msvc...see:conan-io/conan-center-index#26024

Close: jasp-stats/jasp-issues#2884

TODO and Help wanted:

  • Make it work on macOS
  • Implement importing factor level as label

@shun2wang shun2wang marked this pull request as draft April 11, 2025 09:53
@shun2wang shun2wang changed the title support importing R data files into JASP feat: support importing R data files into JASP Apr 11, 2025
@EJWagenmakers
Copy link
Contributor

Awesome!!

@shun2wang shun2wang marked this pull request as ready for review April 11, 2025 12:51
@JorisGoosen
Copy link
Contributor

Looks good at first glance!
Nice ^^

Ill have look next week, and this might even make make some datawrangling easier!

@shun2wang
Copy link
Contributor Author

Is there a way to suppress the compiling warning of R package RcppEigen? it annoying and maks build time too long. @RensDofferhoff

@JorisGoosen
Copy link
Contributor

Is there a way to suppress the compiling warning of R package RcppEigen? it annoying and maks build time too long. @RensDofferhoff

Its a good idea to add this yeah, I like seeing the output of rpkgs being compiled in case there is an error (which is why I turned it on) but rcppeigen is ridiculous

@shun2wang
Copy link
Contributor Author

shun2wang commented Apr 17, 2025 •
edited
Loading

Is there a way to suppress the compiling warning of R package RcppEigen? it annoying and maks build time too long. @RensDofferhoff

Its a good idea to add this yeah, I like seeing the output of rpkgs being compiled in case there is an error (which is why I turned it on) but rcppeigen is ridiculous

Yes, I also support turning on some compilation parameters to identify risks.
Seems it will not be "fixed". see: RcppCore/RcppEigen#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisGoosen JorisGoosen Awaiting requested review from JorisGoosen

@boutinb boutinb Awaiting requested review from boutinb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Importing R data format (Rds and RData)
3 participants
@shun2wang @EJWagenmakers @JorisGoosen