Try to make MD generation robust #5884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorisGoosen
reviewed
May 14, 2025
QMLComponents/controls/jaspcontrol.h
Outdated
Comment on lines
66
to
82
| typedef struct MDItem | ||
| { | ||
| bool isSection = false; | ||
| QString label, | ||
| info; | ||
| std::vector<struct MDItem> children; | ||
|
|
||
| MDItem() {} | ||
| MDItem(const QString& _label) : label{_label} {} | ||
|
|
||
| bool isEmpty() { return label.isEmpty() && info.isEmpty() && children.size() == 0; } | ||
| bool hasHeader() { return !label.isEmpty() || !info.isEmpty(); } | ||
|
|
||
| QString print(int depth = 0) const; | ||
|
|
||
|
|
||
| } MDItem; |
boutinb
force-pushed
the
helpMoreBeautiful
branch
from
5d7e1cb to
d4a7a4a
Compare
|
I have removed the MDItems structure. |
boutinb
force-pushed
the
helpMoreBeautiful
branch
from
9e16efa to
9a61545
Compare
JorisGoosen
reviewed
May 21, 2025
|
|
||
| void JASPControl::setMDSubItems() | ||
| { | ||
| _MDSubItems.clear(); |
There was a problem hiding this comment.
I dont like this at all...
Why do we need this function?
You can just do this determination in the generateMDHelp function...
Or let this return a list of JASPControl*
But why store it?
Then we need to think about when to update it...
JorisGoosen
requested changes
May 21, 2025
Sub items that do not have labels or info, should be set at the same level as their parents. For this, the hierarchy of the items should be kept, before generating the MD string.
boutinb
force-pushed
the
helpMoreBeautiful
branch
from
9a61545 to
2d769b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub items that do not have labels or info, should be set at the same level as their parents. For this, the hierarchy of the items should be kept, before generating the MD string.