fix trim space while value is not unsigned char #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shun2wang
force-pushed
the
fixStringTrim
branch
from
2c7993f to
2ababb4
Compare
|
@boutinb @JorisGoosen This is important fix, it also can fix some import .csv bugs. |
boutinb
approved these changes
Apr 17, 2025
Yes, because this is the result of freexl and this fix. To completely solve the problem, you need to cooperate with freexl patch PR:jasp-stats/jasp-desktop#5775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: jasp-stats/jasp-issues#3074
According the best practices of https://en.cppreference.com/w/cpp/string/byte/isspace it was undefined if the value of ch is not representable as unsigned char.so the problem may not be entirely a defect of freexl.
Note: you may need a clean build of freexl with this PR but not from conanfile.txt.