mdspan-ify and encapsulate state of C++ miniWeather #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is NOT COMPLETE YET. It's a port of cpp/miniWeather_serial.cpp.
Remove some differences (state_tmp allocation and initialization) between Python and C. It didn't change the Python output at all.
Extents of flux in Python differed from those in C. I changed the Python flux allocation to work like C, but that didn't help the mass balance.
PNetCDF wants an MPI_Info that is not MPI_INFO_NULL. There are other issues with C output.
The result is gross, because it involves two "god structs." A better solution would be to separate out the const arrays from the nonconst arrays. An even better solution would be a state object that owns all the allocations, and hands out const or nonconst views as needed.
Encapsulate global arrays in a class that offers (mdspan) views. Make functions take mdspan-of-const where possible.
This helps manage mutable state like the output counter and dt.
This will make parallelization easier.
I haven't tested either of these yet.
Also verify that OpenACC builds define _OPENACC.
* Separate out all the loops that can be parallelized into their own functions * miniWeather_mdspan.cpp is the "generic executable"
That is, a single run of `make` can build both of them.
We have a CUB (ForEachInExtents) version, but it hasn't been tested yet, because HPC SDK 25.1 doesn't have a new enough CUB version yet. Fix stdpar build by using cartesian_product from Gonzalo Brito's tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp-mdspan-encapsulation tag:
Complete mdspan-ification and state encapsulation