Skip to content

add parameter for specifying cache table name #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rinse12
Copy link

@Rinse12 Rinse12 commented Dec 3, 2023

No description provided.

@jkelin
Copy link
Owner

jkelin commented Dec 3, 2023

It's a good idea, thank you for the contribution! Just two things:

  • this will fail if the table name contains spaces or special characters (e.g. cache table)
    • please either use bind parameters
    • or if that does not work (not sure), wrap in double quotes character "
  • please add a test for this new functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants