Replacing old phputf8 with symfony mbstring polyfill #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We've been using the phputf8 library in our StringHelper class, however that class has been abandoned for close to 20 years. We've since been modifying it for our needs anyway and the question came up, if we should still handle it as external library. While reviewing the code, it turns out that most of it can be replaced by calls to the mbstring polyfill from symfony, resulting in smaller and faster code. Since we already include the polyfill in the CMS and 10 other framework packages anyway, it is only reasonable to also include it here.
Testing Instructions
The unittests do cover the StringHelper class very extensively.
Documentation Changes Required
None.