fix(Parse): Solve remote references #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierSierraBlazquez
force-pushed
the
solve-remote-references
branch
from
9ee6113 to
3a1fb21
Compare
JavierSierraBlazquez
force-pushed
the
solve-remote-references
branch
4 times, most recently
from
389ab01 to
530beed
Compare
Swagger-parser resolves circular references with Object references. PathsParser does not handle this case and will result in an infinite loop. fix(ajv-openapi)!: remove draft-04 support To solve an error importing AJV when OpenAPI Mocker is used as API from another application, that is using higher versions of AJV Error: Cannot find module 'ajv/lib/refs/json-schema-draft-04.json' Require stack: [private-path]/[app-using-open-api-mocker-with-higher-ajv-version]/node_modules/ajv-openapi/index.js [private-path]/[app-using-open-api-mocker-with-higher-ajv-version]/node_modules/open-api-mocker/lib/schema-validator/index.js [private-path]/[app-using-open-api-mocker-with-higher-ajv-version]/node_modules/open-api-mocker/lib/paths/path.js [private-path]/[app-using-open-api-mocker-with-higher-ajv-version]/node_modules/open-api-mocker/lib/paths/parser.js [private-path]/[app-using-open-api-mocker-with-higher-ajv-version]/node_modules/open-api-mocker/lib/paths/index.js [private-path]/[app-using-open-api-mocker-with-higher-ajv-version]/node_modules/open-api-mocker/lib/open-api-mocker.js
javier-sierra-sngular
force-pushed
the
solve-remote-references
branch
from
530beed to
41ae193
Compare
|
I've just come across the issue with open-api-mocker bombing out when it encounters a ciruclar reference. I believe that it boils down to an outdated version of Either way, it'd be good to have this merged and released to avoid us having to use github dependencies in our package.json files to fix these small issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched from
json-reftoswagger-parser.json-refwasn't resolving remote references, which caused errors when splitting your schema into different files.swagger-parserresolves circular references using object references.PathsParserdoes not handle this case and will result in an infinite loop.This solution replaces circular references with the provided default value if the number of circular references exceeds the specified depth limit.
Solves #72