Skip to content

Add podLabels parameter #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bueti
Copy link

@bueti bueti commented Apr 28, 2025

Is this a bug fix or adding new feature?
This PR is adding a new feature - enabling users to specify custom pod labels for the FSx CSI driver controller and node components.

What is this PR about? / Why do we need it?
This PR enhances the AWS FSx CSI driver Helm chart by parameterizing pod labels for both the controller deployment and node daemonset. This allows users to add custom labels to the pods, which can be useful for:

  • Better pod identification and filtering in large clusters
  • Integration with monitoring, security, or compliance tools that rely on pod labels
  • Enabling organization-specific labeling standards

The implementation adds new configuration options (controller.podLabels and node.podLabels) to the values.yaml file, which are then applied to the respective pod template specs.

What testing is done?
The changes have been tested by:

  • Verifying that the chart installs successfully with default values
  • Testing the chart with custom pod labels specified for both controller and node components

Copy link

linux-foundation-easycla bot commented Apr 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bueti
Once this PR has been reviewed and has the lgtm label, please assign torredil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 28, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @bueti!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bueti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2025
@@ -19,6 +19,9 @@ spec:
labels:
app: fsx-csi-controller
{{- include "aws-fsx-csi-driver.labels" . | nindent 8 }}
{{- with .Values.controller.podLabels }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an if instead of with?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it makes a big difference, but i changed it anyways :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup basically no difference, we just try to stay consistent with other csi drivers when they already have things set

@kuba-wolf
Copy link
Contributor

Hi @bueti, thanks for the PR. I think you might want to use if instead of with just looking at some other csi drivers. Once you've done the EasyCLA authorization we can move forward with the PR

@bueti
Copy link
Author

bueti commented Apr 29, 2025

Hi @bueti, thanks for the PR. I think you might want to use if instead of with just looking at some other csi drivers. Once you've done the EasyCLA authorization we can move forward with the PR

hey @kuba-wolf , thanks for your review. since this is the first contribution to a cncf repo for my company getting cla done might take a few days, but i am working on it!

@kuba-wolf
Copy link
Contributor

@bueti Can you squash your commits into a single one? Otherwise this looks good to me

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 8, 2025
@bueti bueti force-pushed the add-podLabels-param branch from 9db4e08 to 9e98beb Compare May 9, 2025 13:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2025
@bueti
Copy link
Author

bueti commented May 9, 2025

@bueti Can you squash your commits into a single one? Otherwise this looks good to me

finally got the CLA sorted. Squashed commits and merged master.

@bueti bueti requested a review from kuba-wolf May 13, 2025 06:19
@bueti
Copy link
Author

bueti commented May 14, 2025

@kuba-wolf if you could have another look and give the ok for the tests?

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants