-
Notifications
You must be signed in to change notification settings - Fork 89
Add podLabels parameter #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bueti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @bueti! |
Hi @bueti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -19,6 +19,9 @@ spec: | |||
labels: | |||
app: fsx-csi-controller | |||
{{- include "aws-fsx-csi-driver.labels" . | nindent 8 }} | |||
{{- with .Values.controller.podLabels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an if instead of with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it makes a big difference, but i changed it anyways :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup basically no difference, we just try to stay consistent with other csi drivers when they already have things set
Hi @bueti, thanks for the PR. I think you might want to use |
hey @kuba-wolf , thanks for your review. since this is the first contribution to a cncf repo for my company getting cla done might take a few days, but i am working on it! |
@bueti Can you squash your commits into a single one? Otherwise this looks good to me |
finally got the CLA sorted. Squashed commits and merged master. |
@kuba-wolf if you could have another look and give the ok for the tests? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is this a bug fix or adding new feature?
This PR is adding a new feature - enabling users to specify custom pod labels for the FSx CSI driver controller and node components.
What is this PR about? / Why do we need it?
This PR enhances the AWS FSx CSI driver Helm chart by parameterizing pod labels for both the controller deployment and node daemonset. This allows users to add custom labels to the pods, which can be useful for:
The implementation adds new configuration options (controller.podLabels and node.podLabels) to the values.yaml file, which are then applied to the respective pod template specs.
What testing is done?
The changes have been tested by: