Skip to content

frontend: logViewer: Add toggle button for word break #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vyncent-t
Copy link
Collaborator

This PR adds a toggle button for the Logs Viewer window that allows the text to be formatted for word break.

similar to requested feature from #2657

WIP:

  • not sure if this should be enabled by default

How to test

  • Open headlamp into a cluster
  • Navigate to pods
  • Click on any pod
  • Open the "View logs" button
  • Click the toggle "Word break" button
  • Log text format should change

WIP: need to fix multi click for changes to work

Signed-off-by: Vincent T <vtaylor@microsoft.com>
@vyncent-t vyncent-t self-assigned this Mar 27, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 27, 2025
Copy link
Collaborator

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be good to enable by default, and then have the changes from the other PR as a toggle potentially

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 1, 2025
@illume
Copy link
Collaborator

illume commented Apr 25, 2025

this might be good to enable by default, and then have the changes from the other PR as a toggle potentially

@vyncent-t can you please move this to a new PR if it needs changes? Sounds like it does. cc @skoeva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants