Skip to content

[WIP] app: home: Add delete button for non dynamic clusters #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vyncent-t
Copy link
Contributor

original - #2567

Description

Fixes #1418

This PR updates the cluster deletion functionality in Headlamp to allow users to delete non-dynamic clusters directly from the home page. Previously, only clusters added through Headlamp could be deleted, which led to confusion for users attempting to delete clusters originating from other sources (e.g., kubeconfig).

To address this, the deletion process has been updated to clearly inform users about the impact of deleting a cluster, particularly when the cluster originates from non-Headlamp sources.


Images

image

Changes Made

  1. Updated the cluster deletion functionality to allow deletion of non-dynamic clusters, including those originating from kubeconfig.
  2. Enhanced the deletion confirmation dialog to inform users about the origin of the cluster and to clarify that deleting non-dynamic clusters will also remove them from the kubeconfig file.

Steps to Test

  1. Open the home view in Headlamp.
  2. Add clusters from both Headlamp and kubeconfig.
  3. Attempt to delete clusters:
    • Confirm the dialog accurately informs users about the cluster’s origin.
    • Verify that deleting non-dynamic clusters removes them from kubeconfig.
    • Verify that deleting Headlamp-added clusters functions as expected.

Notes

  • This PR ensures that users have a clear understanding of the impact of deleting clusters.
  • It improves usability by addressing feedback received about the cluster deletion restrictions in earlier versions.

(waiting for merge of improve meta data branch)

Signed-off-by: Vincent T <vtaylor@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyncent-t
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2025
@vyncent-t vyncent-t self-assigned this Apr 15, 2025
@k8s-ci-robot k8s-ci-robot requested review from illume and sniok April 15, 2025 19:57
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 15, 2025
@vyncent-t vyncent-t changed the title app: home: Add delete button for non dynamic clusters [WIP] app: home: Add delete button for non dynamic clusters Apr 15, 2025
@vyncent-t vyncent-t changed the title [WIP] app: home: Add delete button for non dynamic clusters [NEW] [WIP] app: home: Add delete button for non dynamic clusters Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vyncent-t vyncent-t changed the title [NEW] [WIP] app: home: Add delete button for non dynamic clusters [WIP] app: home: Add delete button for non dynamic clusters Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to delete any clusters when using Headlamp (desktop version)
2 participants