-
Notifications
You must be signed in to change notification settings - Fork 334
frontend: Allow direct editing of resource fields #3132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a note about removing the translation changes to use some existing localization strings.
Can you also please make sure to rebase against main? (It took us a while to review this and now it's quite out of date)
36c25dd
to
4e44506
Compare
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, skoeva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes allow the user to directly make changes to fields for configmaps and secrets without having to open the entire resource YAML in the editor dialog.
Fixes: #2412, follow-up from #2994
Testing