Skip to content

frontend: Allow direct editing of resource fields #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Apr 16, 2025

These changes allow the user to directly make changes to fields for configmaps and secrets without having to open the entire resource YAML in the editor dialog.

Fixes: #2412, follow-up from #2994

Testing

  • Navigate to the details page for any configmap or secret
  • Edit the field and hit the save button
  • Ensure that the resource gets updated with the new value

@skoeva skoeva added kind/feature Categorizes issue or PR as related to a new feature. frontend Issues related to the frontend labels Apr 16, 2025
@skoeva skoeva self-assigned this Apr 16, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 16, 2025
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a note about removing the translation changes to use some existing localization strings.

Can you also please make sure to rebase against main? (It took us a while to review this and now it's quite out of date)

@skoeva skoeva force-pushed the edit-fields-2 branch 3 times, most recently from 36c25dd to 4e44506 Compare April 28, 2025 19:50
skoeva added 2 commits April 29, 2025 09:53
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@illume illume merged commit 74157b5 into kubernetes-sigs:main Apr 29, 2025
11 of 12 checks passed
@joaquimrocha joaquimrocha added this to the v0.31.0 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. frontend Issues related to the frontend kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit secrets and configmap fields
4 participants