Skip to content

Update Ganesha, Fedora and GitHub Actions versions #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Ganesha, Fedora and GitHub Actions versions #152

wants to merge 3 commits into from

Conversation

Hi-Fi
Copy link

@Hi-Fi Hi-Fi commented Oct 10, 2024

No description provided.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Hi-Fi!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 10, 2024
@ader1990 ader1990 mentioned this pull request Oct 21, 2024
Closed
@Hi-Fi Hi-Fi force-pushed the update_ganesha branch 5 times, most recently from fccc6d8 to c8a49e0 Compare October 22, 2024 13:38
This was referenced Oct 22, 2024
Merged
Open
@ader1990
Copy link

Hello, can we have this PR merged in a timely manner, as there is a big functionality issue that gets fixed by nfs-ganesha v2. See nfs-ganesha/nfs-ganesha#1188.

Thanks.

@Hi-Fi Hi-Fi mentioned this pull request Nov 9, 2024
Open
@bernardgut
Copy link

Hello @kvaps can you merge this ?

thanks

@dadangnh
Copy link

Hi @wongma7 / @pohly / @msau42 / @kvaps. Kindly help to review this once you have time.

Thanks

@Hi-Fi
Copy link
Author

Hi-Fi commented Jan 12, 2025

Updated Fedora and Ganesha to latest ones so that PR is not old in dependency sense.

Hi-Fi added 3 commits January 12, 2025 17:46
@Hi-Fi
chore: update action versions
6f7780c
@Hi-Fi
feat: update to Ganesha 6.5 and Fedora 41
913ba74 
Using self-compiled ntirpc and including libacl (introduced within Ganesha 5)
@Hi-Fi
feat: mount by default as NFS 4.1
a28b6be
@tanwar57
Copy link

tanwar57 commented Jan 29, 2025 •
edited
Loading

Hello, when can we have this PR to be land to use nfs 4.1, I guess on current tag (v4.0.8), we only have nfs version 3

cc @Hi-Fi am I right here . that current nfs version in the latest image is nfs v3

@Hi-Fi
Copy link
Author

Hi-Fi commented Jan 29, 2025 •
edited
Loading

Hello, when can we have this PR to be land to use nfs 4.1, I guess on current tag (v4.0.8), we only have nfs version 3

cc @Hi-Fi am I right here . that current nfs version in the latest image is nfs v3

@tanwar57 I have done everything I can, PR is waiting for review from owners:

This PR would start using NFS 4.1 by default, not sure if that was supported also earlier version but just default was earlier.

EDIT: Builds were made at the fork, and images published to https://github.com/Hi-Fi/nfs-ganesha-server-and-external-provisioner/pkgs/container/nfs-ganesha

@tanwar57
Copy link

Hello, when can we have this PR to be land to use nfs 4.1, I guess on current tag (v4.0.8), we only have nfs version 3
cc @Hi-Fi am I right here . that current nfs version in the latest image is nfs v3

@tanwar57 I have done everything I can, PR is waiting for review from owners:

This PR would start using NFS 4.1 by default, not sure if that was supported also earlier version but just default was earlier.

@Hi-Fi , I checked actually it is using default v3 . We need this . Thank for your work

@tanwar57
Copy link

@Hi-Fi , can you provide me the link of docker image of the provision using default nfs:v4 , do you have it somewhere (like docker hub etc ..)

@jsafrane
Copy link
Contributor

I am afraid all existing approvers lost interest in this repo. I am going to approve, but I have no way how to test this (or
any other) PR. It would be great if someone has stepped up and added e2e tests, so we can be sure nothing breaks.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HerveHen, Hi-Fi, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@tanwar57
Copy link

tanwar57 commented Mar 18, 2025 •
edited
Loading

Hello Guys, request , can someone please have a look, on this PR

@Hi-Fi
Copy link
Author

Hi-Fi commented Mar 19, 2025 •
edited
Loading

@jsafrane I tested this locally, but it might be different than "real" usage.

Apparently at least tide waits for lgtm label.

@bernardgut
Copy link

Hello again @wongma7 / @pohly / @msau42 / @kvaps

Can one of you add lgtm label to this PR ? We have been waiting for this one for months.

Thanks/

@bernardgut
Copy link

@jsafrane can you add the lgtm label ? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ader1990 ader1990 ader1990 requested changes

@HerveHen HerveHen HerveHen approved these changes

@ashishranjan738 ashishranjan738 Awaiting requested review from ashishranjan738

@kmova kmova Awaiting requested review from kmova

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Hi-Fi @k8s-ci-robot @ader1990 @bernardgut @dadangnh @tanwar57 @jsafrane @HerveHen