Deprecate the ansible provision mode and playbook #3451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
jandubois
approved these changes
Apr 21, 2025
| @@ -277,6 +277,7 @@ func Validate(y *LimaYAML, warn bool) error { | |||
| if _, err := os.Stat(playbook); err != nil { | |||
| return fmt.Errorf("field `provision[%d].playbook` refers to an inaccessible path: %q: %w", i, playbook, err) | |||
| } | |||
| logrus.Warnf("ansible provision mode is deprecated, use `ansible-playbook %q` instead", playbook) | |||
There was a problem hiding this comment.
I'm not sure it is clear to the user that ansible-playbook should be run directly (on the host? inside the VM?), and that it isn't a new lima.yaml setting.
Nit-picking: provision mode "ansible"
AkihiroSuda
reviewed
Apr 21, 2025
| @@ -221,7 +221,7 @@ const ( | |||
| ProvisionModeUser ProvisionMode = "user" | |||
| ProvisionModeBoot ProvisionMode = "boot" | |||
| ProvisionModeDependency ProvisionMode = "dependency" | |||
| ProvisionModeAnsible ProvisionMode = "ansible" | |||
| ProvisionModeAnsible ProvisionMode = "ansible" // DEPRECATED | |||
There was a problem hiding this comment.
https://lima-vm.io/docs/releases/deprecated/ has to be updated
AkihiroSuda
reviewed
Apr 21, 2025
| @@ -256,6 +256,8 @@ containerd: | |||
| # # It requires `ansible-playbook` command to be installed. | |||
| # # Environment variables such as ANSIBLE_CONFIG can be used, to control the behavior of the playbook execution. | |||
| # # See ansible docs, and `ansible-config`, for more info https://docs.ansible.com/ansible/latest/playbook_guide/ | |||
| # # DEPRECATED The ansible mode is deprecated, and should not be used. Instead call ansible-playbook directly, | |||
| # # either from the host after the instance is started or from the instance by running ansible locally instead. | |||
There was a problem hiding this comment.
You can add an /examples/ansible page under https://lima-vm.io/docs/examples/ for ansible-playbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now issues a warning when validated, to be removed completely in a future version.
Closes #3450