[CIR] Make ZeroAttr use AttrBuilderWithInferredContext #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcardosolopes I would also suggest to rename the attribute to I can also add verifier in followup PR to check that it is used only with these types. |
Sounds good to me!
Awesome |
bcardosolopes
approved these changes
Apr 21, 2025
xlauko
force-pushed
the
users/xlauko/cir-zero-attr-builder-with-inferred-context
branch
from
5f092ef to
4b17e83
Compare
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Apr 22, 2025
This mirrors incubator changes from llvm/clangir#1576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.