Add tw prefix to tailwind #1497
Open
+1,090
−1,042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroliu
commented
May 26, 2025
| @@ -450,12 +450,6 @@ If your plugin does not need CSS, delete this file. | |||
| margin: 10px; | |||
| } | |||
|
|
|||
| .message-content-items { | |||
There was a problem hiding this comment.
this classname has been migrated to tailwind
There was a problem hiding this comment.
Pull Request Overview
This PR updates Tailwind integration by adding a tw- prefix to all Tailwind utility classes and enforcing this via new ESLint rules.
- Bulk-renamed all existing className usages to include the
tw-prefix - Added
eslint-plugin-tailwindcssto catch unprefixed or misordered classes - Updated project configs (
components.json,.eslintrc,package.json) to reflect and enforce the new prefix
Reviewed Changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/.../**/*.tsx | Renamed all Tailwind utility classNames to tw-* |
| components.json | Set "prefix": "tw" for component CSS tools |
| .eslintrc | Added TailwindCSS plugin, rules, and updated overrides |
| package.json | Added eslint-plugin-tailwindcss dev dependency |
zeroliu
force-pushed
the
codex/add-tw-prefix-to-tailwindcss-classes
branch
2 times, most recently
from
e6d31fb to
7486a9d
Compare
zeroliu
commented
May 26, 2025
| @@ -15,7 +15,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [20.x] | |||
| node-version: [22.x] | |||
There was a problem hiding this comment.
I updated this when debugging a CI lint test failure. The issue has been resolved and it's unrelated to this. However, I think it's better to upgrade to 22 since it's the LTS version.
|
Thanks for the PR! Will merge this once the preview branch merges. |
zeroliu
force-pushed
the
codex/add-tw-prefix-to-tailwindcss-classes
branch
from
76ac04a to
515f7c4
Compare
zeroliu
force-pushed
the
codex/add-tw-prefix-to-tailwindcss-classes
branch
from
515f7c4 to
e7b32ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
twprefix in Tailwind configuration and component configtw-prefixTesting
I verified the existing UI continue to work as intended. And I used the tailwindcss plugin to ensure all tailwind classnames without tw- are caught