Skip to content

(fleet/cert-manager) remove cert-manager and crds #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

(fleet/cert-manager) remove cert-manager and crds #878

merged 1 commit into from
Apr 28, 2025
+0 −4

Conversation

cbarria
Copy link
Contributor

@cbarria cbarria commented Apr 25, 2025 •
edited
Loading

  • ArgoCD took cert-manager on Pillan, Manke and Yagan.
  • cert-manager-conf is still creating the cluster-issuer

@cbarria cbarria added the enhancement New feature or request label Apr 25, 2025
@cbarria cbarria self-assigned this Apr 25, 2025
dtapiacl
dtapiacl approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@dtapiacl dtapiacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

jhoblitt
jhoblitt requested changes Apr 28, 2025
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ s/con/from/

@cbarria
Copy link
Contributor Author

cbarria commented Apr 28, 2025

~ s/con/from/

i think i meant to write "on" and took an extra "c" with the space bar, fixed.

@dtapiacl
Copy link
Contributor

~ s/con/from/

I didn't even see that, good catch on that typo.

@cbarria cbarria force-pushed the IT-6120_remove_certmanager branch from 8c3a09d to 87fc67c Compare April 28, 2025 19:48
@cbarria cbarria merged commit 1de4691 into master Apr 28, 2025
9 checks passed
@cbarria cbarria deleted the IT-6120_remove_certmanager branch April 28, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

@dtapiacl dtapiacl dtapiacl approved these changes

@gseriche gseriche Awaiting requested review from gseriche

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

@igonzalezcl igonzalezcl Awaiting requested review from igonzalezcl

@hstockeb hstockeb Awaiting requested review from hstockeb

@badenerb badenerb Awaiting requested review from badenerb

Assignees

@cbarria cbarria

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbarria @dtapiacl @jhoblitt