Small cleanup, removed duplicated keys from array #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

hostep wants to merge 1 commit into magento:develop from hostep:cleanup-remove-duplicated-keys-in-array

Contributor

hostep commented Apr 19, 2025 •

edited

Loading

'proc_open' => null, is already defined in the same array on line 38, it makes no sense to keep both around.

Found with phpstan (while running it from inside magento core codebase):

$ ./vendor/bin/phpstan analyse --level=0 -c dev/tests/static/testsuite/Magento/Test/Php/_files/phpstan/phpstan.neon vendor/magento | grep 'duplicate'
 3325/3325 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

  28     Array has 2 duplicate keys with value 'proc_open' ('proc_open', 'proc_open').


          Small cleanup, removed duplicated keys from array

05947d5

hostep mentioned this pull request

Small cleanup, removed duplicated keys from array magento/magento2#39844

Open

5 tasks

fredden approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet