WIP: Using DGL instead of Torch Geometric #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gennarinoos
commented
Feb 4, 2025
•
gennarinoos
commented
- Update and fix unit tests
- Fix CI environment setup
- Check if point sampler probabilities are negative
- Double check arch changes (graphconv instead of devconv)
- Re-enable surface distance loss
- Re-enable surface distance loss
- Double check algorithm complies with the one on the paper
Fixing, disabling or removing tests, too
Clean up diff
Extra debug logging
| @@ -38,7 +39,7 @@ def test_find_nearest_triangles(loss_fn): | |||
|
|
|||
| nearest = loss_fn.find_nearest_triangles(vertices, faces) | |||
| assert nearest.shape[0] == faces.shape[0] | |||
| assert nearest.shape[1] == 1 # k-1 = 1, since k=2 | |||
| assert nearest.shape[1] == k_val | |||
There was a problem hiding this comment.
I believe the comment from before does not fit anymore. The function will only return less than k if the number of centroids are less than k. Before we found the k nearest and remove self connections - DGL's function always returns k number of neighbours regardless of exclude self.
Co-authored-by: Martin Høst Normark <m@martinnormark.com>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.