-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Seeed Solar Node #6763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Seeed Solar Node #6763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should rename the json file in boards/
, and the directory in variants/
as well 🙏
do those ones matter like this? I know we've had issues with the env name having caps before so that's why I changed it here. I will if you think it would be wise. |
4218f03
to
98e0d32
Compare
@rcarteraz your patch changes the board name, not the env name. If you change the board name, the json file needs to be named accordingly, this is matched 1:1. The directory name is a 'nice to have' to stay in line. |
Ahh, yeah I think I confused myself. I see what he meant now, thank you for clarifying. I've updated everything. |
lowercase