Skip to content

Update Seeed Solar Node #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 14, 2025
Merged

Update Seeed Solar Node #6763

merged 8 commits into from
May 14, 2025

Conversation

rcarteraz
Copy link
Member

lowercase

Copy link
Member

@vidplace7 vidplace7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rename the json file in boards/, and the directory in variants/ as well 🙏

@rcarteraz rcarteraz requested a review from thebentern May 8, 2025 03:04
@rcarteraz
Copy link
Member Author

You should rename the json file in boards/, and the directory in variants/ as well 🙏

do those ones matter like this? I know we've had issues with the env name having caps before so that's why I changed it here. I will if you think it would be wise.

@caveman99 caveman99 force-pushed the rcarteraz-patch-1 branch from 4218f03 to 98e0d32 Compare May 13, 2025 11:48
@caveman99
Copy link
Member

@rcarteraz your patch changes the board name, not the env name. If you change the board name, the json file needs to be named accordingly, this is matched 1:1. The directory name is a 'nice to have' to stay in line.

@rcarteraz
Copy link
Member Author

@rcarteraz your patch changes the board name, not the env name. If you change the board name, the json file needs to be named accordingly, this is matched 1:1. The directory name is a 'nice to have' to stay in line.

Ahh, yeah I think I confused myself. I see what he meant now, thank you for clarifying. I've updated everything.

@thebentern thebentern merged commit b1955c3 into master May 14, 2025
3 checks passed
@caveman99 caveman99 deleted the rcarteraz-patch-1 branch June 5, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants