Skip to content

device-install.sh: detect t-eth-elite as s3 device #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

chri2
Copy link
Contributor

@chri2 chri2 commented May 8, 2025

Fixes #6754 (comment)

Thanks @mverch67!

Installed a Lilygo T-ETH-Elite using this patch and it worked. Should be tested against a different esp32 s3 and non-s3 device also, but I do not have access to any.

Any help testing other esp32 devices is appreciated!

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • [x ] I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other: Lilygo T-ETH-Elite

@CLAassistant
Copy link

CLAassistant commented May 8, 2025

CLA assistant check
All committers have signed the CLA.

@fifieldt
Copy link
Member

fifieldt commented May 8, 2025

Thanks @chri2 ! Are you able to sign the CLA?

@mverch67
Copy link
Collaborator

mverch67 commented May 10, 2025

While you're on this I suggest to also add the other missing devices in this S3_VARIANTS list:

"mesh-tab"
"dreamcatcher"
"ESP32-S3-Pico"
"seeed-sensecap-indicator"
"heltec_capsule_sensor_v3"
"vision-master"
"icarus"
"tracksenger"
"elecrow-adv"

@caveman99 caveman99 force-pushed the install_t-eth-elite branch from 82665f0 to e9f470a Compare May 13, 2025 12:11
@caveman99 caveman99 merged commit a741579 into meshtastic:master May 13, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error running device-install.sh from 2.6.6 for Lilygo t-eth-elite
6 participants