Strip BOM character from column keys when parsing header, add BOM tests #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokoli
requested changes
May 21, 2025
|
Oops, sorry for that. I removed the obsolete test and the console.log |
pokoli
approved these changes
May 30, 2025
|
I merged the changes, thanks for contributing in the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #372, stripping BOM from column keys when parsing the header.
The problem: The first column key includes the invisible BOM character if it exists in the CSV.
Pull request #961 handled BOM stripping for parsing the CSV without keyed data. However, with
header: truethe issue still persisted. This is solved by this pull request that runs thestripBomfunction from #961 also on the header field, before 'transformHeader'.Also, I added tests for BOM handling.