Skip to content

chore: migrate repo to use ts #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 19, 2024
Merged

chore: migrate repo to use ts #112

merged 6 commits into from
Sep 19, 2024

Conversation

ajayagr
Copy link
Contributor

@ajayagr ajayagr commented Sep 19, 2024 •
edited
Loading

This PR upgrades the repo to make use of TS along with exiting JS implementation to rules.

Changes added:

  • Added packages for working with TS.
  • Added tsconfig.
  • Added jest as test runner for ts tests.
  • Updated the main file to point to distribution folder instead of main index.js

Post these changes, the below change will be required whenever pushing any rule update

  • Add new rule, run the command npm run build to ensure build files get generated.
  • Push both the new rules as well the generated rules

@ajayagr ajayagr self-assigned this Sep 19, 2024
@ajayagr ajayagr linked an issue Sep 19, 2024 that may be closed by this pull request
investigate how to migrate the repo from ES5 to Typescript #86
Closed
@aubreyquinn aubreyquinn merged commit 209b736 into main Sep 19, 2024
4 checks passed
@aubreyquinn aubreyquinn deleted the ajayagr/migrate-repo-to-ts branch September 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aubreyquinn aubreyquinn aubreyquinn approved these changes

Assignees

@ajayagr ajayagr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate how to migrate the repo from ES5 to Typescript
2 participants
@ajayagr @aubreyquinn