Skip to content

Python: Update InMemory and Faiss #12117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Updates for in-memory and faiss connectors

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner May 16, 2025 07:59
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels May 16, 2025
@github-actions github-actions bot changed the title Update InMemory and Faiss Python: Update InMemory and Faiss May 16, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 16, 2025

Python Unit Test Overview

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 22 🔥 44.082s ⏱️

@eavanvalkenburg eavanvalkenburg force-pushed the vector_store_updates_in_memory_faiss branch from 27e725c to e614abc Compare May 19, 2025 17:24
@eavanvalkenburg eavanvalkenburg force-pushed the vector_store_updates_in_memory_faiss branch from e614abc to acf2240 Compare May 20, 2025 07:31
@eavanvalkenburg eavanvalkenburg merged commit 1eca217 into microsoft:feature-python-vector-stores-preb May 21, 2025
5 of 17 checks passed
eavanvalkenburg added a commit that referenced this pull request May 22, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Updates for in-memory and faiss connectors

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
eavanvalkenburg added a commit to eavanvalkenburg/semantic-kernel that referenced this pull request May 22, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Updates for in-memory and faiss connectors

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
eavanvalkenburg added a commit to eavanvalkenburg/semantic-kernel that referenced this pull request May 26, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Updates for in-memory and faiss connectors

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants