Skip to content

fix(interceptor): fix rpc exception message in http to grpc interceptor #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions lib/interceptors/grpc-to-http.interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,34 +29,18 @@ export class GrpcToHttpInterceptor implements NestInterceptor {
)
return throwError(() => err);

const statusCode =
HTTP_CODE_FROM_GRPC[err.code] || HttpStatus.INTERNAL_SERVER_ERROR;

let exception: { exceptionName: any; error: any; type?: string };
try {
exception = JSON.parse(err.details) as {
error: string | object;
type: string;
exceptionName: string;
};
} catch (parseError) {
return throwError(
() =>
new HttpException(
{
message: err.details,
statusCode,
error: HttpStatus[statusCode],
},
statusCode,
{ cause: err },
),
);
}
const exception = JSON.parse(err.details) as {
error: string | object;
type: string;
exceptionName: string;
};

if (exception.exceptionName !== RpcException.name)
return throwError(() => err);

const statusCode =
HTTP_CODE_FROM_GRPC[err.code] || HttpStatus.INTERNAL_SERVER_ERROR;

return throwError(
() =>
new HttpException(
Expand Down
7 changes: 6 additions & 1 deletion lib/interceptors/http-to-grpc.interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ export class HttpToGrpcInterceptor implements NestInterceptor {
return throwError(
() =>
new RpcException({
message: exception.message,
message: JSON.stringify({
error: exception.message,
type:
typeof exception.message === "string" ? "string" : "object",
exceptionName: RpcException.name,
}),
code: statusCode,
}),
);
Expand Down