chore: add tests for read operations #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14640623132Details
💛 - Coveralls |
gagik
approved these changes
Apr 24, 2025
|
|
||
| export const AggregateArgs = { | ||
| pipeline: z.array(z.object({}).passthrough()).describe("An array of aggregation stages to execute"), | ||
| limit: z.number().optional().default(10).describe("The maximum number of documents to return"), |
There was a problem hiding this comment.
I'm a bit worried about this, we should run the MCP against a very very large collection and ask for all documents: #108
There was a problem hiding this comment.
That wasn't previously used, so figured it's better to remove it rather than lie to the model. Agree that we should investigate mechanisms to mitigate that risk post initial release.
nirinchev
force-pushed
the
ni/integration-read
branch
from
09b74ec to
b5b5edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.