chore: switch to @mongodb-js/device-id
#196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is meant to minimize code replication and to make sure the approach we're taking with hashing is consistent.
gagik
commented
May 5, 2025
| @@ -1,5 +1,5 @@ | |||
| /** @type {import('ts-jest').JestConfigWithTsJest} **/ | |||
| export default { | |||
There was a problem hiding this comment.
I ran into jestjs/jest#15312, possibly because of a TypeScript update, so just going to keep it as a .cjs file for the time being
gagik
commented
May 8, 2025
| this.deviceIdPromise = getDeviceId({ | ||
| getMachineId: () => this.getRawMachineId(), | ||
| onError: (reason, error) => { | ||
| switch (reason) { |
There was a problem hiding this comment.
honestly seeing this used like this does make me think we should instead throw typed error objects and check instanceof as reason feels a bit redundant but this is fine
There was a problem hiding this comment.
Yeah, I was debating between the two for a while - ended up going with a reason because that was more explicit about the possible values as opposed to Error inheritors, where you'd need to figure out what the options are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is meant to minimize code replication and to make sure the approach we're taking with hashing is consistent and timeouts are automatically handled.
See mongodb-js/devtools-shared#532